Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog for Module editing #42423

Merged
merged 28 commits into from Jan 14, 2024
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 29, 2023

Summary of Changes

Use Dialog for module editing modals.

Affects:

  • Dashboard: add module
  • Menus: add/edit module
  • Menu item: Module Assignment tab

Any other place I forgot?

Testing Instructions

Run npm install,

Test:

  • Dashboard: add module
  • Menus: add/edit module
  • Menu item, in Module Assignment tab: edit module

Actual result BEFORE applying this Pull Request

Works with BS modal

Expected result AFTER applying this Pull Request

Works with new dialog

Link to documentations

Please select:

References:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Nov 29, 2023
@Fedik Fedik marked this pull request as draft November 29, 2023 16:15
@Fedik Fedik added the Feature label Nov 29, 2023
@Fedik Fedik marked this pull request as ready for review December 2, 2023 08:57
@Fedik Fedik mentioned this pull request Dec 2, 2023
4 tasks
@Fedik Fedik deleted the popup-module-edit branch January 14, 2024 17:09
@Quy Quy added this to the Joomla! 5.1.0 milestone Jan 14, 2024
@Quy Quy removed the RTC This Pull Request is Ready To Commit label Jan 15, 2024
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 22, 2024
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 10, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 10, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 11, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 25, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 1, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 2, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 3, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 3, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 15, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 19, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 1, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 2, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 7, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants