New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Use Dialog for Module editing #42423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.1-dev
labels
Nov 29, 2023
4 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jan 22, 2024
4 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Feb 10, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Feb 10, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
4 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Feb 11, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Feb 25, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 1, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 2, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
2 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 3, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 3, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 4, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 15, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 19, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 1, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 2, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 7, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
This was referenced Apr 17, 2024
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use Dialog for module editing modals.
Affects:
Any other place I forgot?
Testing Instructions
Run
npm install
,Test:
Actual result BEFORE applying this Pull Request
Works with BS modal
Expected result AFTER applying this Pull Request
Works with new dialog
Link to documentations
Please select:
References: