Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Nov 29, 2023

Summary of Changes

Use Dialog for module editing modals.

Affects:

  • Dashboard: add module
  • Menus: add/edit module
  • Menu item: Module Assignment tab

Any other place I forgot?

Testing Instructions

Run npm install,

Test:

  • Dashboard: add module
  • Menus: add/edit module
  • Menu item, in Module Assignment tab: edit module

Actual result BEFORE applying this Pull Request

Works with BS modal

Expected result AFTER applying this Pull Request

Works with new dialog

Link to documentations

Please select:

References:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Nov 29, 2023
@Fedik Fedik marked this pull request as draft November 29, 2023 16:15
@Fedik Fedik added the Feature label Nov 29, 2023
@Fedik Fedik marked this pull request as ready for review December 2, 2023 08:57
@Fedik Fedik mentioned this pull request Dec 2, 2023
4 tasks
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 3, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 15, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 19, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 28, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 1, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 2, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 7, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 12, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 25, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 18, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 24, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 8, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 27, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 3, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 11, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 17, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 18, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 18, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 26, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 30, 2024
Add directories to skip for js files removed with PRs joomla#42082 and joomla#42423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants