Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link and button colors in header footer of Cassiopeia template #42504

Merged
merged 4 commits into from Dec 20, 2023

Conversation

RickR2H
Copy link
Member

@RickR2H RickR2H commented Dec 13, 2023

Rework of issue PR #41749
Pull Request for Issue #42302

Summary of Changes

In previous PR's the colors for the buttons and links in the header and footer where broken. This PR fixed those issues,

  • Obsolete styling is removed
  • Added correct colors to the header and footer buttons and links
  • Fix hover state of scroll to top button

Testing Instructions

Create 3 custom html modules in the positions: topbar / footer / bottom-b
Make sure you toggle the editor to Source code+ (Click in the editor Tools -> Source code+)
Use the code below in the modules and paste as in the Source code+ ans click Save.

<a href="#" class="btn btn-primary">Primary</a>
<a href="#" class="btn btn-secondary">Secondary</a>
<a href="#" class="btn btn-success">Success</a>
<a href="#" class="btn btn-danger">Danger</a>
<a href="#" class="btn btn-warning">Warning</a>
<a href="#" class="btn btn-info">Info</a>
<a href="#" class="btn btn-light">Light</a>
<a href="#" class="btn btn-dark">Dark</a>
<a href="#" class="btn btn-link">Button link</a>
<a href="#">Default Link</a>

Test if all button color are correct, also the hover state.
Test the frontend edit buttons
Switch the scroll to top icon to On in the template settings to test the scroll to top hover color

Actual result BEFORE applying this Pull Request

Some buttons and links texts are not visible
20231213-image-before

Expected result AFTER applying this Pull Request

All colors are visible
20231213-image-after

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Dec 16, 2023

The Download is not available (Expected — Waiting for status to be reported).

@alikon
Copy link
Contributor

alikon commented Dec 16, 2023

the Prebuilt Download Packages are available here https://artifacts.joomla.org/drone/joomla/joomla-cms/4.4-dev/42504/downloads/72256

@sandewt
Copy link
Contributor

sandewt commented Dec 17, 2023

Thanks for this pr.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42504.

@sandewt
Copy link
Contributor

sandewt commented Dec 17, 2023

I have tested this item ✅ successfully on 22dc444


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42504.

@Quy
Copy link
Contributor

Quy commented Dec 18, 2023

I have tested this item ✅ successfully on 22dc444


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42504.

@Quy Quy added the RTC This Pull Request is Ready To Commit label Dec 18, 2023
@MacJoom MacJoom self-assigned this Dec 20, 2023
@MacJoom MacJoom merged commit 3aa5fa9 into joomla:4.4-dev Dec 20, 2023
2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 20, 2023
@MacJoom
Copy link
Contributor

MacJoom commented Dec 20, 2023

Thank you!

@MacJoom MacJoom added this to the Joomla! 4.4.2 milestone Dec 20, 2023
Razzo1987 added a commit that referenced this pull request Jan 4, 2024
* Fix link and button colors in header footer (#42504)

* [4.x] add php 8.3 to tests (#42545)

* Update the signature for #42545 (#42552)

* [4.4] Joomlaupdate remove br tag from language strings - follow up to PR 42489 (#42550)

* Better English (1)

* Better English (2)

* Remove br html element from language strings

* Fixes to form validation process (#42560)

Fixes hardening measure introduced in #23716

* [4][com_actionlogs] missed load plugin languages (#42562)

* load lang

* test-4-dupkey

* Better message on package uninstallation (#42570)

* Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .

* backport #41865 (#42088)

* backport [5] update from nightly to latest nightly build #41865

* [5] harmonize naming task types (#42574)

* [5.0] colour contrast in media manager file list [a11y] (#42544)

* [5.0] Update phpseclib to 3.0.34 (#42469)

* Fix `function` parameter lost during redirect (#42315)

* Fix `function` parameter lost during redirect

* Move function parameter to form url

* Remove hidden input

* [4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576)

* Use concat of columns for getting core extensions

* Fix PHPCS

* Remove wrong quotes

* Revert min version in drone (#42583)

* Joomla! 5.0.2 Release Candidate 1

* Revert to dev

* [4][com_templates] cast to int for pgsql (#42569)

* cast to int for pgsql

* yet-another

* patch article tags (#42486)

* Joomla 5.0.2 Release Candidate 2

* Reset to dev

* Update signature HMAC in .drone.yml

---------

Co-authored-by: Rick Spaan <rick@r2h.nl>
Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Benjamin Trenkle <benjamin.trenkle@wicked-software.de>
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: janschoenherr <jan@yootheme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants