Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4][com_templates] cast to int for pgsql #42569

Merged
merged 4 commits into from Dec 31, 2023
Merged

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Dec 26, 2023

Pull Request for Issue #42408 .

Summary of Changes

cast to int

Testing Instructions

Packages for new installation and update with this PR applied and a custom update URL can be found here: https://artifacts.joomla.org/drone/joomla/joomla-cms/4.4-dev/42569/downloads/72523

use postgresql
"System" -> "Site Templates", in the drop-down list select: "Site", then "Cassiopeia Details and Files" and move to the editor.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

able to edit

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

I have tested this item ✅ successfully on 8c8371a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42569.

@ambltsk
Copy link

ambltsk commented Dec 30, 2023

I have tested this change, I confirm it works.

@richard67
Copy link
Member

I have tested this change, I confirm it works.

@ambltsk Thanks for testing. Could you mark your test result in the issue tracker so it's properly counted? For doing this, just go to https://issues.joomla.org/tracker/joomla-cms/42569 , then use the blue "Test this" button at the top left corner, select your test result (success) and finally submit. Thanks in advance.

@ambltsk
Copy link

ambltsk commented Dec 30, 2023

I have tested this item ✅ successfully on 8c8371a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42569.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42569.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 30, 2023
@MacJoom MacJoom self-assigned this Dec 31, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.2 milestone Dec 31, 2023
@MacJoom MacJoom merged commit f97a4c5 into joomla:4.4-dev Dec 31, 2023
2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 31, 2023
@alikon alikon deleted the patch-24 branch December 31, 2023 17:16
Razzo1987 added a commit that referenced this pull request Jan 4, 2024
* Fix link and button colors in header footer (#42504)

* [4.x] add php 8.3 to tests (#42545)

* Update the signature for #42545 (#42552)

* [4.4] Joomlaupdate remove br tag from language strings - follow up to PR 42489 (#42550)

* Better English (1)

* Better English (2)

* Remove br html element from language strings

* Fixes to form validation process (#42560)

Fixes hardening measure introduced in #23716

* [4][com_actionlogs] missed load plugin languages (#42562)

* load lang

* test-4-dupkey

* Better message on package uninstallation (#42570)

* Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .

* backport #41865 (#42088)

* backport [5] update from nightly to latest nightly build #41865

* [5] harmonize naming task types (#42574)

* [5.0] colour contrast in media manager file list [a11y] (#42544)

* [5.0] Update phpseclib to 3.0.34 (#42469)

* Fix `function` parameter lost during redirect (#42315)

* Fix `function` parameter lost during redirect

* Move function parameter to form url

* Remove hidden input

* [4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576)

* Use concat of columns for getting core extensions

* Fix PHPCS

* Remove wrong quotes

* Revert min version in drone (#42583)

* Joomla! 5.0.2 Release Candidate 1

* Revert to dev

* [4][com_templates] cast to int for pgsql (#42569)

* cast to int for pgsql

* yet-another

* patch article tags (#42486)

* Joomla 5.0.2 Release Candidate 2

* Reset to dev

* Update signature HMAC in .drone.yml

---------

Co-authored-by: Rick Spaan <rick@r2h.nl>
Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Benjamin Trenkle <benjamin.trenkle@wicked-software.de>
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: janschoenherr <jan@yootheme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants