New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Header list field #42736
Merged
Merged
[5.1] Header list field #42736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add header for listfield * added in the parent, so removet from SQL
Quy
reviewed
Jan 31, 2024
Quy
reviewed
Jan 31, 2024
fix spaces Co-authored-by: Quy <quy@nomonkeybiz.com>
fix spaces pt2 Co-authored-by: Quy <quy@nomonkeybiz.com>
Thanks @Quy ! |
I have tested this item ✅ successfully on 9c12907 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42736. |
I have tested this item ✅ successfully on 9c12907 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42736. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42736. |
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42736. |
I see the benefit of this PR, but there should be the following considerations:
|
bembelimen
added
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Mar 1, 2024
Ok, @LadySolveig fought for this PR and convinced me, that we should merge it, so here we go! |
Thx |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Language Change
This is for Translators
PBF
Pizza, Bugs and Fun
PR-5.1-dev
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving @brianteeman PR #41122 to extend to field lists.
Thanks to @alikon for the support.
Summary of Changes
Extending the possibility of using the header to list fields as well.
So moving some code from
SqlField.php
toListField.php
.Testing Instructions
Create a file of type List
Create a file of type SQL
Create a XML field and add header option
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
You may now specify the header
The SQL field still works
now you can add the header from XML too
Link to documentations
Please select:
Documentation link for docs.joomla.org: List_form_field_type
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Note:
Eg of SQL query for SQL Field (you need to create some articles for example from sample data):
Eg of XML list field: