New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Adding notice to global configuration for additional options in SEF plugin #42832
[5.1] Adding notice to global configuration for additional options in SEF plugin #42832
Conversation
Co-authored-by: Quy <quy@nomonkeybiz.com>
I have tested this item ✅ successfully on e42c9d5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832. |
Sorry, this looks wrong, the layout already have "description" rendering, joomla-cms/layouts/joomla/content/options_default.php Lines 26 to 28 in e42c9d5
Need to look why it does not work as expected. |
No, this is a different description. |
Then we have to fix that, instead of hardcoding. From what I see the description already expected from |
The fix is this PR here. |
Why? |
The description need to be added here
Beside $this->name :
But, this also means that every other layouts in
Otherwise, the last added description will be rendered in all following layouts. |
Yes, and that is why this shouldn't be done like that. The whole layout obviously has only been created for the global configuration and has not been maintained properly so far. For example, the whole rendering of fields can be replaced with |
Co-authored-by: Quy <quy@nomonkeybiz.com>
Sorry, I cannot follow your logic. If someone want to rewrite whole rendering, well, I do not mind. But then it should be done for whole view, not only here. |
@Fedik
|
I understood that, but as you can see To have a better styling can probably change joomla-cms/layouts/joomla/content/options_default.php Lines 26 to 28 in e42c9d5
to: <?php if (!empty($displayData->description)) : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo $displayData->description; ?>
</div>
<?php endif; ?> Similar to what you made, but with use of 'expected' |
…bal configuration options_default
@LadySolveig looks good now, thanks! |
I have tested this item ✅ successfully on e8f9963 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832. |
1 similar comment
I have tested this item ✅ successfully on e8f9963 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832. |
I have tested this item ✅ successfully on c9f426a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832. |
1 similar comment
I have tested this item ✅ successfully on c9f426a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832. |
Thank you! |
Pull Request for PR #42692 #42702 #42704 .
Summary of Changes
Add note to gloabl configuration for additional options in system plugin SEF
Testing Instructions
/administrator/index.php?option=com_config
Actual result BEFORE applying this Pull Request
no notice shown
Expected result AFTER applying this Pull Request
notice shown in section/fieldset "SEO"
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed