Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mod_stats to service provider #42781

Merged
merged 7 commits into from Feb 25, 2024
Merged

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the statistics module to service provider.

Testing Instructions

  1. Make sure you have site module mod_stats published
  2. You should see module output on frontend

mod_stats

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Feb 11, 2024

I have tested this item ✅ successfully on 2d04b85


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42781.

@fgsw
Copy link

fgsw commented Feb 13, 2024

I have tested this item ✅ successfully on 2e7ac4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42781.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 2e7ac4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42781.

@alikon
Copy link
Contributor

alikon commented Feb 13, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42781.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 13, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 24, 2024
@LadySolveig LadySolveig merged commit c044810 into joomla:5.1-dev Feb 25, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 25, 2024
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby and also to testers @fgsw @viocassel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants