Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Update deleted files list in script.php for 5.1.0-beta1 #42935

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Mar 1, 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in file administrator/components/com_admin/script.php to recent changes in the 5.1-dev branch in preparation for the upcoming 5.1.0-beta1 release.

In detail deleted files and folder from following PR's are added:

The following JS files which were deleted with PR #42776 in the source code shall not be deleted on update for b/c reasons, so they are not added to the list in file administrator/components/com_admin/script.php with this PR:
/media/legacy/js/treeselectmenu.js
/media/legacy/js/treeselectmenu.min.js
/media/legacy/js/treeselectmenu.min.js.gz

These files need to be added to the list of exceptions in the build/deleted_file_check.php so they will not be reported in future as false alarms by the tool which I used to generate the changes of this PR. See my current PR #42936 for that.

Testing Instructions

Code review.

Or if you want to make a real test, update a 5.1.0-alpha4 or older version to the last 5.1 nightly build to get the actual result, and update a 5.1.0-alpha4 or older version to to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

The files and folders mentioned above are still present after updating from a 5.1.0-alpha4 or older version.

Expected result AFTER applying this Pull Request

The files mentioned above have been deleted after updating from a 5.1.0-alpha4 or older version.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@bembelimen bembelimen merged commit baa889d into joomla:5.1-dev Mar 2, 2024
3 checks passed
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 2, 2024
@richard67 richard67 deleted the 5.1-dev-deleted-files-and-folders-2024-03-01 branch March 3, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants