Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Convert mod_version to service provider #42814

Merged
merged 16 commits into from Feb 26, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the version administrator module to service provider.

Testing Instructions

  1. Make sure you have administrator module mod_version published
  2. You should see module output

mod_messages

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Feb 15, 2024

I have tested this item ✅ successfully on 366e884


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42814.

@ceford
Copy link
Contributor

ceford commented Feb 20, 2024

I have tested this item ✅ successfully on 6be703c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42814.

@richard67
Copy link
Member

@fgsw Could you test this PR again? Thanks in advance.

@fgsw
Copy link

fgsw commented Feb 20, 2024

@fgsw Could you test this PR again? Thanks in advance.

No re-test. Reason: comment.

@richard67
Copy link
Member

@fgsw I've restored the result from your previous test in the issue tracker since the changes after that were code style only.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42814.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 20, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 24, 2024
@LadySolveig LadySolveig merged commit dacda5c into joomla:5.1-dev Feb 26, 2024
3 checks passed
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby for your work and your endurance!
I am of course also very very happy and grateful for the tests @fgsw @ceford and the cs-fix @richard67

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants