Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Convert mod_syndicate to service provider #42883

Merged
merged 2 commits into from Feb 26, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the syndicate link site module to service provider.

Testing Instructions

  1. Make sure you have site module mod_syndicate published
  2. Make sure you have RSS Feed link enabled in Articles component configuration (Integration tab)
  3. You should see module output on articles listing menu items - Category blog, Featured articles...
  4. You should not see module output on other menu item types - Single Article, other components...

mod_syndicate

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Feb 26, 2024

I have tested this item ✅ successfully on fdcea5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42883.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on fdcea5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42883.

@Hackwar Hackwar added the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@richard67 richard67 removed RTC This Pull Request is Ready To Commit PR-5.1-dev labels Feb 26, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42883.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@LadySolveig LadySolveig merged commit f1524f3 into joomla:5.1-dev Feb 26, 2024
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby and also for testing @fgsw @viocassel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants