Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Convert mod_tags_popular to service provider #42899

Merged
merged 3 commits into from Feb 28, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the popular tags site module to service provider.

Testing Instructions

  1. Make sure you have site module mod_tags_popular published
  2. Add some tags and assign them to several content items
  3. You should see module output
  4. You should not see module output, when all tags are unpublished/deleted and "Show No results text" module setting is disabled.
  5. You should see module output with no results message, when all tags are unpublished/deleted and "Show No results text" module setting is enabled.

mod_tags_popular

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Feb 27, 2024

I have tested this item ✅ successfully on 46f56aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42899.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 46f56aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42899.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42899.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 27, 2024
@LadySolveig LadySolveig merged commit d36ef9a into joomla:5.1-dev Feb 28, 2024
0 of 2 checks passed
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 28, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 28, 2024
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby and also to the testers @fgsw @viocassel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants