[5.1] Dark Mode final Version #42986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CS - thanks for the suggestions Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss Co-authored-by: Brian Teeman <brian@teeman.net>
…s-dark.scss Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss Co-authored-by: Brian Teeman <brian@teeman.net>
LTR
RTL
Same issue repeated in dark mode |
|
Go to Media Manager. |
|
Install the plugin. |
|
|
fixed for darkmode, lightmode needs to go into separate PR |
…l' into dark-mode-5.1-dev-final
This reverts commit ba0e780.
|
Thank you very much for the great work and your commitment @coolcat-creations and @MacJoom ! 💟 🚀 |
4 tasks
This was referenced Mar 11, 2024
|
System --> Guided Tours, when hovering the cursor
|
|
@Kostelano thank you for the finding. As this is merged, can you please open a new issue ? |
4 tasks
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Apr 2, 2024
joomla/joomla-cms#42966 - (только для en-GB) joomla/joomla-cms#42953 + joomla/joomla-cms#42986 + joomla/joomla-cms#42221 + joomla/joomla-cms#41659 + joomla/joomla-cms#43061 + joomla/joomla-cms#43054 - (только для en-GB) joomla/joomla-cms#42995 - (только для en-GB) joomla/joomla-cms#43115 + joomla/joomla-cms#43147 + + Upmerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #42757 and #42010 for Joomla 5.1
Summary of Changes
Dark mode modifications and improvements
Testing Instructions
Turn on dark mode in your browser or O/S
Actual result BEFORE applying this Pull Request
old dark mode
Expected result AFTER applying this Pull Request
improved dark mode