Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Guided tours welcome tour #41659

Merged
merged 73 commits into from Mar 13, 2024

Conversation

obuisard
Copy link
Contributor

@obuisard obuisard commented Sep 7, 2023

Summary of Changes

Adds a welcome tour to Joomla 5.
On new installs, the welcome tour is triggered automatically.
On updates, the welcome tour does not load, it needs to be manually requested.
When in the dashboard, the welcome tour should be among the first tours in the list of tours.

Testing Instructions

Create a new install.
Upon login and once in the dashboard, the welcome tour starts.
Once started, the tour can be cancelled.
The tour will not autostart a second time.

Update from 4.4 or a 5.0 beta 1 or earlier.
Upon login, the welcome tour does not start, but is present in the list of contextual tours.

It is possible to 'fake' the autostart by changing the column 'autostart' value of the welcome tour to 1 in the #__guidedtours table.

Actual result BEFORE applying this Pull Request

No welcome tour.

Expected result AFTER applying this Pull Request

A welcome tour.

Note

This is not an implementation of the autostart feature that is planned for 5.1.
This version of autostart is very basic to at least provide a welcome tour that autostart for newcomers on a first install.
The additional tour column 'autostart' will be used in further developments of the feature.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 7, 2023
@obuisard obuisard changed the title Guided tours welcome tour [5.0] Guided tours welcome tour Sep 8, 2023
@brianteeman
Copy link
Contributor

i can see why this tour is a good idea.
i am not sure if you are really showing the most important parts.
for example I would talk about adding a language and creating sample data.

finaly the tone/voice of the language used is, for me, not appropriate. When you use a metaphor or a simile then it makes it much harder to be understood by someone who is not a native speaker.

perhaps @ceford can help you with the text

Added extra space
Removed language-specific expressions
@obuisard obuisard marked this pull request as ready for review September 13, 2023 19:01
@brianteeman
Copy link
Contributor

Please avoid using the word "click" and instead use the word "select". You can't click with a keyboard or with your finger.

Please avoid using metaphores and similes - they are difficult, and sometimes impossible, to understand if english is not your native language

@softforge
Copy link
Contributor

I have tested this item ✅ successfully on c6c30a9

Worked like a dream. Well done all


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41659.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on de42648


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41659.

@obuisard
Copy link
Contributor Author

obuisard commented Sep 15, 2023

I have tested this item 🔴 unsuccessfully on de42648

Hi Brian @brianteeman, did you fail the PR because of technicality or because of the wording?
The tour is short on purpose and not touching all areas of the dashboard (we would like to create a more elaborate tour for that). The tone is meant to give it some energy and enthusiasm.
If you think some sentences are still not quite right, what would you say instead?
Thank for your feedback.

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 46804ac

I tested it and didn't notice any problems.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41659.

@LadySolveig LadySolveig merged commit 7f710fb into joomla:5.1-dev Mar 13, 2024
0 of 2 checks passed
@LadySolveig
Copy link
Contributor

Thank you so much for the work on this very useful feature 🎉 ❤️ @obuisard and everyone who supported this through reviewing, texting and testing.

@obuisard
Copy link
Contributor Author

Thank you so much for the work on this very useful feature 🎉 ❤️ @obuisard and everyone who supported this through reviewing, texting and testing.

Thank you Martina! This is a great team effort. Thank you to Phil @softforge and Shirielle @sdwjoomla who provided us with a new tour! Great thanks to Benjamin @bembelimen for the support and help throughout ('til the end!), to Harald @HLeithner for the help in our first attempt to get the PR merged to the core, and thank you to the reviewers and spotters for the wording and the code (among all Brian @brianteeman, Cliff @ceford, Fedir @Fedik). This kind of PR needs feedback and it is great to see people pitching in. Finally, thanks to the testers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet