Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Guided Tours Welcome Text Update Step 1 #43061

Merged
merged 5 commits into from Mar 17, 2024

Conversation

coolcat-creations
Copy link
Contributor

@coolcat-creations coolcat-creations commented Mar 16, 2024

Improve and shorten text for the welcome Guided Tour to add more clarity about what the tour is about.

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Improve Text for welcome
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Mar 16, 2024
@coolcat-creations coolcat-creations changed the title Update guidedtours.joomla_welcome.ini [5.1] Guided Tours Welcome Text Update Step 1 Mar 16, 2024
@brianteeman
Copy link
Contributor

I agree its too long

But this proposed text is not describing the same thing as the original.

And my 2c "there is nothing fun about building a web site for your job"

@coolcat-creations
Copy link
Contributor Author

Okay, I removed the fun part @brianteeman

@sandewt
Copy link
Contributor

sandewt commented Mar 16, 2024

Joomla or Joomla! ? Both occur here. My suggestion is Joomla! (with an exclamation mark) only in the tittle.

remove bang inside text
@coolcat-creations
Copy link
Contributor Author

Removed the Bang before "site".

@brianteeman
Copy link
Contributor

/me still does see this proposed text as having the same intended meaning as the original concept text

@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Mar 17, 2024
@bembelimen bembelimen enabled auto-merge (squash) March 17, 2024 11:14
@LadySolveig LadySolveig merged commit 2593dc9 into joomla:5.1-dev Mar 17, 2024
1 of 3 checks passed
@LadySolveig
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants