[5.1] Update deleted files list in script.php for 5.1.0-rc1 (2) #43168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Follow up PR to #43095 .
This pull request (PR) updates the list of files to be deleted on update in file
administrator/components/com_admin/script.phpto recent changes in the 5.1-dev branch in preparation for the upcoming 5.1.0-rc1 release.Up to now there is only one file
/media/vendor/punycode/LICENSE-MIT.txtadded to the list of files and one folder/media/vendor/punycodeto the list of folder, both from PR #43162 , but we should check again tomorrow afternoon if something new comes.Testing Instructions
Code review.
Or if you want to make a real test, update a 5.1.0-beta2 or older version to the last 5.1 nightly build to get the actual result, and update a 5.1.0-beta1 or older version to to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
The file and the folder mentioned above are still present after updating from a 5.1.0-beta2 or older version.
Expected result AFTER applying this Pull Request
The file and the folder mentioned above have been deleted after updating from a 5.1.0-beta2 or older version.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed