Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Update deleted files list in script.php for 5.1.0-rc1 #43095

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Mar 19, 2024

Pull Request for Issue # .

Summary of Changes

Follow up PR to #42955 and #43045 .

This pull request (PR) updates the list of files to be deleted on update in file administrator/components/com_admin/script.php to recent changes in the 5.1-dev branch in preparation for the upcoming 5.1.0-beta2 release.

There is only one file added to the list of files, which is file /administrator/modules/mod_post_installation_messages/mod_post_installation_messages.php from PR #42987 .

Testing Instructions

Code review.

Or if you want to make a real test, update a 5.1.0-beta2 or older version to the last 5.1 nightly build to get the actual result, and update a 5.1.0-beta1 or older version to to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

The file mentioned above is still present after updating from a 5.1.0-beta2 or older version.

Expected result AFTER applying this Pull Request

The file mentioned above has been deleted after updating from a 5.1.0-beta2 or older version.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title [5.1] Update deleted files list in script.php for 5.1.0-beta2 (3) [5.1] Update deleted files list in script.php for 5.1.0-rc1 Mar 19, 2024
@bembelimen bembelimen merged commit bc08a3d into joomla:5.1-dev Mar 19, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thanks!

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 19, 2024
@richard67 richard67 deleted the 5.1-dev-deleted-files-and-folders-2024-03-19 branch March 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants