New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Upmerges 2024-05-08 #43446
Merged
Merged
[5.1] Upmerges 2024-05-08 #43446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
…ions (joomla#43336) * a * b * Update LocalAdapter.php
…eck CLI (joomla#43208) * Untranslated string for warning message in update:extensions:check CLI * Move language load to command. ---------
…3274) * Update LocalAdapter.php * Update LocalAdapter.php ---------
…oomla#43259) * Determine the next task run date with the timezone of the site * cs ---------
* [4.4] Vote : aggregateRating error in Google Rich Results * Update rating.php * Update rating.php Replace tabs by spaces * Update plugins/content/vote/tmpl/rating.php Co-authored-by: jsanders <j53.sanders@gmail.com> * Update rating.php remove itemscope redefinition ---------
After discussion with Alikon the fix is simple 10 milliseconds waiting time after changing sorting order. The five failures were reproducable in 4.4-dev and ifixed and it is expected it works for 5.1 the same way.
* Contact VCF: properly assign to array * Update components/com_contact/src/View/Contact/VcfView.php ---------
* Fix ordering for files in the template view * Rewrite getDirectoryTree function using early return and uksort * CS * Use natural sorting instead of string comparison ---------
bembelimen
requested review from
laoneo,
chmst,
HLeithner,
rdeutz,
Hackwar and
zero-24
as code owners
May 8, 2024 19:04
joomla-cms-bot
added
the
NPM Resource Changed
This Pull Request can't be tested by Patchtester
label
May 8, 2024
richard67
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed