Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL syntax error on update to 3.4.1-rc with mysql/3.4.0-2015-02-26.sql #6478

Merged

Conversation

richard67
Copy link
Member

Steps to reproduce the issue

Update a multilingual Joomla <= 3.4.0 to a 3.4.1-rc on a system with msql database.

Expected result

The update succeeds. In post-install messages a new message with title COM_CPANEL_MSG_LANGUAGEACCESS340_TITLE should be shown.

Actual result

An SQL error is shown as follows for the insert statement for this new post-install message, the syntax error I have marked with bold italics:

An error has occurred.

    1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'admin://components/com_admin/postinstall/languageaccess340.php', 'admin_postinst' at line 2 SQL=INSERT INTO `c6gp0_postinstall_messages` (`extension_id`, `title_key`, `description_key`, `action_key`, `language_extension`, `language_client_id`, `type`, `action_file`, `action`, `condition_file`, `condition_method`, `version_introduced`, `enabled`) VALUES (700, 'COM_CPANEL_MSG_LANGUAGEACCESS340_TITLE', 'COM_CPANEL_MSG_LANGUAGEACCESS340_BODY', '', 'com_cpanel', 1, 'message', ', '', 'admin://components/com_admin/postinstall/languageaccess340.php', 'admin_postinstall_languageaccess340_condition', '3.4.1', 1);

Note the unclosed single quote of the value for column action!

System information (as much as possible)

Database driver type is MySQLi, Joomla version see title.

Additional comments

Check of the SQL updates scripts 3.4.0-2015-02-26.sql has shown that the error was only in the one for MySQLi.

Added missing single quote which caused SQL syntax error.
mbabker added a commit that referenced this pull request Mar 17, 2015
…-26_sql

SQL syntax error on update to 3.4.1-rc with mysql/3.4.0-2015-02-26.sql
@mbabker mbabker merged commit 750c9ff into joomla:staging Mar 17, 2015
@richard67
Copy link
Member Author

Fastest merge ever 👍

@richard67 richard67 deleted the correct_updates_3.4.0-2015-02-26_sql branch March 17, 2015 21:43
@infograf768 infograf768 mentioned this pull request Mar 18, 2015
@zero-24
Copy link
Contributor

zero-24 commented Mar 18, 2015

Thanks for fast the fix and merge @richard67 and @mbabker

@zero-24 zero-24 added this to the Joomla! 3.4.1 milestone Apr 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants