Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of npm overrides #127

Open
joonashak opened this issue Apr 16, 2023 · 0 comments
Open

Get rid of npm overrides #127

joonashak opened this issue Apr 16, 2023 · 0 comments
Labels
/client Frontend issue.
Milestone
Stable Release

Comments

@joonashak
Copy link
Owner

joonashak commented Apr 16, 2023 •
edited
Loading

react-scripts does not have typescript@5 as a peer dependency. TS added to client/package.json overrides to make npm ci pass.

Once react-scripts is updated, get rid of the overrides section:

Issue
PR

Later on, frontend should probably be migrated to use Next.js(?).
@joonashak joonashak converted this from a draft issue Apr 16, 2023
@joonashak joonashak added /client Frontend issue. devops Infrastructure, tooling, etc. and removed devops Infrastructure, tooling, etc. labels Apr 16, 2023
@joonashak joonashak added this to the Stable Release milestone Apr 16, 2023
joonashak added a commit that referenced this issue Apr 16, 2023
@joonashak
Add typescript to npm overrides because of upstream incompatibility #127
9b13d21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
/client Frontend issue.
Projects
Holenav Development
Status: To do
Milestone
Stable Release
Development

No branches or pull requests
1 participant
@joonashak