Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check authentication before authenticating #95

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

joostlek
Copy link
Owner

@joostlek joostlek commented Aug 3, 2023

Proposed Changes

(Describe the changes and rationale behind them)

Related Issues

(Github link to related issues or pull requests)

@joostlek joostlek added new-feature New features or options. minor This PR causes a minor version bump in the version number. labels Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #95 (5379999) into main (a80d4af) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          214       227   +13     
  Branches        20        21    +1     
=========================================
+ Hits           214       227   +13     
Files Changed Coverage Δ
src/python_opensky/opensky.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@joostlek joostlek merged commit c3377a5 into main Aug 3, 2023
17 checks passed
@joostlek joostlek deleted the authentication branch August 3, 2023 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
minor This PR causes a minor version bump in the version number. new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant