add possibility to pass preconfigured http client to reuse http/tls resources for consequent requests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use it (together with connections) for consequent requests
|
Hi @samfrown, thank you for the PR. For me is a good idea, so I've reviewed the PR and for me is able to be merged |
|
Thanks @henryx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This address the known issue from the base repo: BetterCloud#239.
The idea is to pass a preconfigured HttpClient to VaultConfig and then reuse it by consequent requests done by the same Vault instance. This improves performance and takes full advantages of HTTP/2 protocol by sharing http connections.
The changes cover only user API so far.