Extend configuration #28
Conversation
anywhere `neovim` package is exposed by this flake, a new property, `extendConfiguration` is made available to allow extending previous configurations/modules in place. This allows e.g. a global package with minimal LSP support to contain users configurations, and per-project shell.nix to enable the language servers needed by that project. Also, allow users to more easily extend .#nix and .#maximal packages to include their customizations.
Modules "default" configs should be set with `mkOptionDefault`, allowing users to use `mkDefault` or others to set their options, which then can be customized downstream with `neovim.extendConfiguration`. `mainConfig` also receives an `overridable` value of 1200, allowing user's `mkDefault=1000` to override it while overriding modules's `mkOptionDefault=1500` properly.
| check = args.check or check; | ||
| extraSpecialArgs = extraSpecialArgs // (args.extraSpecialArgs or {}); | ||
| }) | ||
| .neovim; |
There was a problem hiding this comment.
| .neovim; |
From my understanding, the result of the function does not require being .neovim. I would rather the output of extendConfiguration be identical to neovimConfiguration (as the module exports some useful information).
There was a problem hiding this comment.
Hmm, my ide ahere is that neovimConfiguration is already exported as a function, and since this property would be come a method in neovim, it'd make sense that it also returned another neovim, to be used in place; maybe we could have a top-level extendConfiguration returning the whole set, and the property in neovim returning the package directly?
There was a problem hiding this comment.
If you do not have the time for figuring out the changes, I can take this PR over. But I do not want to step on your work as this is a great solution.
There was a problem hiding this comment.
Please, feel free to take it over; 10mo baby here is requiring additional time this week, and I won't have time to implement for a couple of days. I'm happy to have contributed at least the idea, but of course you as creator has the best big picture view to make it right. Thanks
Fixes #23
Gives
neovimpackages aextendConfigurationproperty, which is a method allowing users to extend this package's configurations with additional modules.This allows users e.g. to derive
.#nixconfig to generate their own config, assign that to globalneovimpackage, and then in per-project'sshell.nix, expand the config to include additional LSP modules or plugins, instead of having to redefine everything fromneovimConfiguration.