Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few CPAN issues #1610

Closed
wants to merge 3 commits into from
Closed

Fix a few CPAN issues #1610

wants to merge 3 commits into from

Conversation

jordansissel
Copy link
Owner

This builds off of the excellent work done by @wbraswell in #1528.

This PR should fix:

Because there are known test failures on master, testing on master vs this PR locally shows:

  • master: 13 failures
  • this pr: 13 failures

For this, I believe nothing broke in this PR, but the above issues should be fixed. When I test the known cases, they work for me; specifically, the following all fail on master but succeed on this PR.

  • bin/fpm --debug -s cpan -t rpm --no-cpan-test Inline::CPP
  • bin/fpm --verbose --no-cpan-test -s cpan -t rpm Alien::astyle
  • bin/fpm --verbose --no-cpan-test -s cpan -t rpm Class::Data::Inheritable

jordansissel and others added 3 commits February 22, 2019 22:20
@jordansissel
Always close stdin when running without a block.
ae9594e 
This prevents subprocesses from mistakenly getting stuck trying to read
from a stdin that won't say anything ;)

Fixes #1519 and #1522.
@wbraswell @jordansissel
Fix some CPAN modules which don't work with --strip-components 1
241db36 
Some tarballs have leading `./` which breaks our `--strip-components`
assumption.

Fixes #1517
@wbraswell @jordansissel
Perl CPAN Support, Missing 'author' Field, Fix
a65c117 
Fixes #1523
@jordansissel jordansissel mentioned this pull request Feb 23, 2019
Closed
@NicholasBHubbard NicholasBHubbard mentioned this pull request Oct 25, 2022
Closed
@NicholasBHubbard NicholasBHubbard mentioned this pull request Nov 6, 2022
Merged
@jordansissel
Copy link
Owner Author

Closing based on the work done recently by @NicholasBHubbard and @wbraswell (#1944, #1955, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordansissel @wbraswell