Feature: type the contents of a file (or stdin) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /* determine whether reading from a file or from stdin */ | ||
| if (!strcmp(file, "-")) { | ||
| input = fdopen(0, "r"); |
There was a problem hiding this comment.
you can simply do 'input = stdin' here :)
There was a problem hiding this comment.
btw, I'll fix this, don't worry about it!
|
Excellent idea. No worries about the docs (and test) changes, I'll take care of those. I'll test and merge shortly! :) |
jordansissel
added a commit
that referenced
this pull request
Dec 15, 2011
Feature: type the contents of a file (or stdin)
|
Thanks, hope others find this feature useful. Nice code by the way; very easily hackable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a flag to the 'type' command (--file) which allows the contents of a file (or standard input) to be typed before (and in addition to) strings given as arguments. This would allow typing sensitive things (like passwords) that you don't want to have show up in process lists, command-line histories, or system logs.
Usage
xdotool type --file <somefile.txt
xdotool type --file - <<END
yada yada yada
END
You get the idea.
Caveats
Patch only makes the code changes. The pod is not updated to reflect this feature nor are any tests added.