Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced formatting of the default css template #137

Merged
merged 2 commits into from
Feb 25, 2014
Merged

Enhanced formatting of the default css template #137

merged 2 commits into from
Feb 25, 2014

Conversation

uberrobert
Copy link
Contributor

  • Used one selector per line for a given ruleset
  • Added spaces after colons, commas and before braces
  • Removed unnecessary new lines

Before:

.rlp-balloon-white,.rlp-mag-black,.rlp-arrow-previous,.rlp-arrow-next{
    background-image:url('/images/sprites/rlp.png');
    background-repeat:no-repeat;
}

@media screen and (-webkit-min-device-pixel-ratio: 1.0), screen and (min--moz-device-pixel-ratio: 1.0),screen and (-o-min-device-pixel-ratio: 100/100),screen and (min-device-pixel-ratio: 1.0),screen and (min-resolution: 1.0dppx){
    .rlp-balloon-white, 
    .rlp-mag-black, 
    .rlp-arrow-previous, 
    .rlp-arrow-next
    {
        background-image:url('/images/sprites/rlp.png');
        -webkit-background-size: 41px 221px;
        -moz-background-size: 41px 221px;
        background-size: 41px 221px;
    }
}

After:

.rlp-balloon-white,
.rlp-mag-black,
.rlp-arrow-previous,
.rlp-arrow-next {
    background-image: url('/images/sprites/rlp.png');
    background-repeat: no-repeat;
}

@media screen and (-webkit-min-device-pixel-ratio: 1.0), screen and (min--moz-device-pixel-ratio: 1.0), screen and (-o-min-device-pixel-ratio: 100/100), screen and (min-device-pixel-ratio: 1.0), screen and (min-resolution: 1.0dppx) {
    .rlp-balloon-white,
    .rlp-mag-black,
    .rlp-arrow-previous,
    .rlp-arrow-next {
        background-image: url('/images/sprites/rlp.png');
        -webkit-background-size: 41px 221px;
        -moz-background-size: 41px 221px;
        background-size: 41px 221px;
    }
}

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 392fff6 on uberrobert:master into 13357a8 on jorgebastida:master.

jorgebastida pushed a commit that referenced this pull request Feb 25, 2014
Enhanced formatting of the default css template
@jorgebastida jorgebastida merged commit d71f221 into jorgebastida:master Feb 25, 2014
@jorgebastida
Copy link
Owner

Thank you very much @uberrobert this new output looks quite better indeed.

@uberrobert
Copy link
Contributor Author

You're welcome @jorgebastida and glad to help!

@jorgebastida
Copy link
Owner

released as part of glue 0.9.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants