make failes #48
Comments
|
Hi. What is your fish-shell version? Because this: is weird. |
|
mdziardziel@PC-076 ~/g/fisherman> fish --version |
|
This is a fish-shell version problem, one fix that comes to mind is extracting the index update logic to a Another fix is to upgrade to fish, version 2.2.0, of course, but maybe there is a reason you are using this version? If you can afford upgrading to 2.2, do so and this should be fixed. Otherwise, I will make sure the install does not fail for 2.1.1 for the next milestone. |
|
Ok, upgrading fish helped. |
ghost
reopened this
|
@Fiedzia Good to know. I will still ship a simple fix for those non-2.2.0 users (there are some I guess) in the next milestone so I'll have this open for now. |
ghost
mentioned this issue
|
Closing in favor of #50. |
ghost
mentioned this issue
ghost
pushed a commit
that referenced
this issue
Feb 1, 2016
Add user key bindings support. (See #42). Recall $fisher_home/functions are always before user functions in $fish_function_path. This was an early design decision in order to prevent users from redefining core functions by mistake or by means other than using plugins (recommended). In other words, you are free to create a plugin that modifies a Fisherman core function, but you can't redefine a Fisherman function privately by saving it to your user config fish. If you found a bug in a Fisherman function, instead of creating a private patch send it upstream. If you created a function that overrides a Fisherman core feature, create a plugin. This way the community can benefit from your code whenever you are ready to publish it. By default, Fisherman provides no fish_user_key_bindings, so if the user has already defined their own fish_user_key_bindings that one will not be affected. Now, plugins can define their own key bindings inside a fish_user_key_bindings.fish or key_bindings.fish at the root of their repository or inside a functions directory. You can put your key bindings inside a function or not. If you put it inside a function, the function name must be the same as the file without the .fish extension. $fisher_config/bindings.fish When a plugin with key bindings is installed for the first time or the only one with bindings is uninstalled, Fisherman will modify ~/.config/functions/fish_user_key_bindings.fish (or create it for the first time) and add a single line at the top of the fish_user_key_bindings function to source the new $fisher_config/bindings.fish. All the key bindings defined by the enabled/installed plugins are concatenated and saved to this file. This mechanism has the following advantages: Does not slow down shell start. Does not require Fisherman to provide his own fish_user_key_bindings by default. Honors any previously existing user key bindings. Allows plugin to define their own key bindings and coexist with the user's key bindings. If the user updates his fish_user_key_bindings, re-running the function does update the key bindings. Mega Refactoring The entire source code of Fisherman received a major revision and refactoring. The validation and install/uninstall mechanisms were thoroughly revised and and broken down into smaller functions easier to test as well as several other sub parts of the system. Rewrite fisher search and remove features that are mostly already covered by fisher --list and remove the ability to generate information about plugins of unknown origin. The decision to remove this feature was based in performance concerns and the result of thinking about the usability and whether it was really worth the speed tradeoff. The conclusion is I would rather have better performance and if I need to query a plugins origin I can always use fisher --list or fisher --list=url or fisher --list=author. Add $fisher_update_interval to determine if the index should update or not when a search query is taking place. The default value is 10 seconds. This means the index will not be updated if less than 10 seconds have elapsed since the last action that triggered an update in the first place. See Improve Install/Uninstall/Update status output. If a plugin fails to install decrease the total. If any plugins are skipped because they are already installed in the case of fisher install or available in the cache, but disabled in the case of fisher uninstall they are collected into an array and displayed in a new section n plugin/s skipped (a, b, c) at the bottom of the report. Improve test coverage. Tightly coupled functions were making testing increasingly difficult. Most of the test effort was basically testing whether git clone or git pull. New separation of concerns makes tests run faster and the difficult install/uninstall algorithms has better coverage now. Other Now __fisher_list can list plugins from the cache, a fishfile/bundle and plugins that are installed/enabled or disabled. This removes __fisher_file and combines it with __fisher_list. This also removes fisher -f and replaces it with fisher -l <file> or fisher --list=<file>. Rename __fisher_parse_help to __fisher_complete and have the function create the completions automatically. This allows you to complete your commands with parseable usage help faster. The original design was fine, but this change improves auto-complete performance so it was preferred. Use __fisher_index_update when building file with Make. This helps prevent an error when using a fish version < 2.2.0. See #55 #50 #48. Add __fisher_index_update to update the index and remove previously undocumented fisher update --index. This function is designed to bypass GitHub's server network cache passing an arbitrary query string to curl like $fisher_index?RANDOM_NUMBER. This means index updates are immediately available now. Add fisher --list=url option to display local plugin url or path. Add fisher --list=bare option to display local plugins in the cache without the * enabled symbol. Prepend > to the currently enabled theme when using fisher --list[=cache]. Related #49. Prepend * to plugin names to indicate they are currently enabled when using fisher --list[=cache]. See #49.
ghost
pushed a commit
that referenced
this issue
Feb 1, 2016
Recall $fisher_home/functions are always before user functions in $fish_function_path. This was an early design decision in order to prevent users from redefining core functions by mistake or by means other than using plugins (recommended). In other words, you are free to create a plugin that modifies a Fisherman core function, but you can't redefine a Fisherman function privately by saving it to your user config fish. If you found a bug in a Fisherman function, instead of creating a private patch send it upstream. If you created a function that overrides a Fisherman core feature, create a plugin. This way the community can benefit from your code whenever you are ready to publish it. By default, Fisherman provides no fish_user_key_bindings, so if the user has already defined their own fish_user_key_bindings that one will not be affected. Now, plugins can define their own key bindings inside a fish_user_key_bindings.fish or key_bindings.fish at the root of their repository or inside a functions directory. You can put your key bindings inside a function or not. If you put it inside a function, the function name must be the same as the file without the .fish extension. $fisher_config/bindings.fish When a plugin with key bindings is installed for the first time or the only one with bindings is uninstalled, Fisherman will modify ~/.config/functions/fish_user_key_bindings.fish (or create it for the first time) and add a single line at the top of the fish_user_key_bindings function to source the new $fisher_config/bindings.fish. All the key bindings defined by the enabled/installed plugins are concatenated and saved to this file. This mechanism has the following advantages: Does not slow down shell start. Does not require Fisherman to provide his own fish_user_key_bindings by default. Honors any previously existing user key bindings. Allows plugin to define their own key bindings and coexist with the user's key bindings. If the user updates his fish_user_key_bindings, re-running the function does update the key bindings. Mega Refactoring The entire source code of Fisherman received a major revision and refactoring. The validation and install/uninstall mechanisms were thoroughly revised and and broken down into smaller functions easier to test as well as several other sub parts of the system. Rewrite fisher search and remove features that are mostly already covered by fisher --list and remove the ability to generate information about plugins of unknown origin. The decision to remove this feature was based in performance concerns and the result of thinking about the usability and whether it was really worth the speed tradeoff. The conclusion is I would rather have better performance and if I need to query a plugins origin I can always use fisher --list or fisher --list=url or fisher --list=author. Add $fisher_update_interval to determine if the index should update or not when a search query is taking place. The default value is 10 seconds. This means the index will not be updated if less than 10 seconds have elapsed since the last action that triggered an update in the first place. See Improve Install/Uninstall/Update status output. If a plugin fails to install decrease the total. If any plugins are skipped because they are already installed in the case of fisher install or available in the cache, but disabled in the case of fisher uninstall they are collected into an array and displayed in a new section n plugin/s skipped (a, b, c) at the bottom of the report. Improve test coverage. Tightly coupled functions were making testing increasingly difficult. Most of the test effort was basically testing whether git clone or git pull. New separation of concerns makes tests run faster and the difficult install/uninstall algorithms has better coverage now. Other Now __fisher_list can list plugins from the cache, a fishfile/bundle and plugins that are installed/enabled or disabled. This removes __fisher_file and combines it with __fisher_list. This also removes fisher -f and replaces it with fisher -l <file> or fisher --list=<file>. Rename __fisher_parse_help to __fisher_complete and have the function create the completions automatically. This allows you to complete your commands with parseable usage help faster. The original design was fine, but this change improves auto-complete performance so it was preferred. Use __fisher_index_update when building file with Make. This helps prevent an error when using a fish version < 2.2.0. See #55 #50 #48. Add __fisher_index_update to update the index and remove previously undocumented fisher update --index. This function is designed to bypass GitHub's server network cache passing an arbitrary query string to curl like $fisher_index?RANDOM_NUMBER. This means index updates are immediately available now. Add fisher --list=url option to display local plugin url or path. Add fisher --list=bare option to display local plugins in the cache without the * enabled symbol. Prepend > to the currently enabled theme when using fisher --list[=cache]. Related #49. Prepend * to plugin names to indicate they are currently enabled when using fisher --list[=cache]. See #49.
ghost
pushed a commit
that referenced
this issue
Feb 1, 2016
===================== Add user key bindings support. Recall $fisher_home/functions are always before user functions in $fish_function_path. This was an early design decision in order to prevent users from redefining core functions by mistake or by means other than using plugins (recommended). In other words, you are free to create a plugin that modifies a Fisherman core function, but you can't redefine a Fisherman function privately by saving it to your user config fish. If you found a bug in a Fisherman function, instead of creating a private patch send it upstream. If you created a function that overrides a Fisherman core feature, create a plugin. This way the community can benefit from your code whenever you are ready to publish it. By default, Fisherman provides no fish_user_key_bindings, so if the user has already defined their own fish_user_key_bindings that one will not be affected. Now, plugins can define their own key bindings inside a fish_user_key_bindings.fish or key_bindings.fish at the root of their repository or inside a functions directory. You can put your key bindings inside a function or not. If you put it inside a function, the function name must be the same as the file without the .fish extension. $fisher_config/bindings.fish When a plugin with key bindings is installed for the first time or the only one with bindings is uninstalled, Fisherman will modify ~/.config/functions/fish_user_key_bindings.fish (or create it for the first time) and add a single line at the top of the fish_user_key_bindings function to source the new $fisher_config/bindings.fish. All the key bindings defined by the enabled/installed plugins are concatenated and saved to this file. This mechanism has the following advantages: Does not slow down shell start. Does not require Fisherman to provide his own fish_user_key_bindings by default. Honors any previously existing user key bindings. Allows plugin to define their own key bindings and coexist with the user's key bindings. If the user updates his fish_user_key_bindings, re-running the function does update the key bindings. Mega Refactoring The entire source code of Fisherman received a major revision and refactoring. The validation and install/uninstall mechanisms were thoroughly revised and and broken down into smaller functions easier to test as well as several other sub parts of the system. Rewrite fisher search and remove features that are mostly already covered by fisher --list and remove the ability to generate information about plugins of unknown origin. The decision to remove this feature was based in performance concerns and the result of thinking about the usability and whether it was really worth the speed tradeoff. The conclusion is I would rather have better performance and if I need to query a plugins origin I can always use fisher --list or fisher --list=url or fisher --list=author. Add $fisher_update_interval to determine if the index should update or not when a search query is taking place. The default value is 10 seconds. This means the index will not be updated if less than 10 seconds have elapsed since the last action that triggered an update in the first place. See Improve Install/Uninstall/Update status output. If a plugin fails to install decrease the total. If any plugins are skipped because they are already installed in the case of fisher install or available in the cache, but disabled in the case of fisher uninstall they are collected into an array and displayed in a new section n plugin/s skipped (a, b, c) at the bottom of the report. Improve test coverage. Tightly coupled functions were making testing increasingly difficult. Most of the test effort was basically testing whether git clone or git pull. New separation of concerns makes tests run faster and the difficult install/uninstall algorithms has better coverage now. Other Now __fisher_list can list plugins from the cache, a fishfile/bundle and plugins that are installed/enabled or disabled. This removes __fisher_file and combines it with __fisher_list. This also removes fisher -f and replaces it with fisher -l <file> or fisher --list=<file>. Rename __fisher_parse_help to __fisher_complete and have the function create the completions automatically. This allows you to complete your commands with parseable usage help faster. The original design was fine, but this change improves auto-complete performance so it was preferred. Use __fisher_index_update when building file with Make. This helps prevent an error when using a fish version < 2.2.0. See #55 #50 #48. Add __fisher_index_update to update the index and remove previously undocumented fisher update --index. This function is designed to bypass GitHub's server network cache passing an arbitrary query string to curl like $fisher_index?RANDOM_NUMBER. This means index updates are immediately available now. Add fisher --list=url option to display local plugin url or path. Add fisher --list=bare option to display local plugins in the cache without the * enabled symbol. Prepend > to the currently enabled theme when using fisher --list[=cache]. Related #49. Prepend * to plugin names to indicate they are currently enabled when using fisher --list[=cache]. See #49.
jorgebucaran
pushed a commit
that referenced
this issue
Sep 21, 2016
===================== Add user key bindings support. Recall $fisher_home/functions are always before user functions in $fish_function_path. This was an early design decision in order to prevent users from redefining core functions by mistake or by means other than using plugins (recommended). In other words, you are free to create a plugin that modifies a Fisherman core function, but you can't redefine a Fisherman function privately by saving it to your user config fish. If you found a bug in a Fisherman function, instead of creating a private patch send it upstream. If you created a function that overrides a Fisherman core feature, create a plugin. This way the community can benefit from your code whenever you are ready to publish it. By default, Fisherman provides no fish_user_key_bindings, so if the user has already defined their own fish_user_key_bindings that one will not be affected. Now, plugins can define their own key bindings inside a fish_user_key_bindings.fish or key_bindings.fish at the root of their repository or inside a functions directory. You can put your key bindings inside a function or not. If you put it inside a function, the function name must be the same as the file without the .fish extension. $fisher_config/bindings.fish When a plugin with key bindings is installed for the first time or the only one with bindings is uninstalled, Fisherman will modify ~/.config/functions/fish_user_key_bindings.fish (or create it for the first time) and add a single line at the top of the fish_user_key_bindings function to source the new $fisher_config/bindings.fish. All the key bindings defined by the enabled/installed plugins are concatenated and saved to this file. This mechanism has the following advantages: Does not slow down shell start. Does not require Fisherman to provide his own fish_user_key_bindings by default. Honors any previously existing user key bindings. Allows plugin to define their own key bindings and coexist with the user's key bindings. If the user updates his fish_user_key_bindings, re-running the function does update the key bindings. Mega Refactoring The entire source code of Fisherman received a major revision and refactoring. The validation and install/uninstall mechanisms were thoroughly revised and and broken down into smaller functions easier to test as well as several other sub parts of the system. Rewrite fisher search and remove features that are mostly already covered by fisher --list and remove the ability to generate information about plugins of unknown origin. The decision to remove this feature was based in performance concerns and the result of thinking about the usability and whether it was really worth the speed tradeoff. The conclusion is I would rather have better performance and if I need to query a plugins origin I can always use fisher --list or fisher --list=url or fisher --list=author. Add $fisher_update_interval to determine if the index should update or not when a search query is taking place. The default value is 10 seconds. This means the index will not be updated if less than 10 seconds have elapsed since the last action that triggered an update in the first place. See Improve Install/Uninstall/Update status output. If a plugin fails to install decrease the total. If any plugins are skipped because they are already installed in the case of fisher install or available in the cache, but disabled in the case of fisher uninstall they are collected into an array and displayed in a new section n plugin/s skipped (a, b, c) at the bottom of the report. Improve test coverage. Tightly coupled functions were making testing increasingly difficult. Most of the test effort was basically testing whether git clone or git pull. New separation of concerns makes tests run faster and the difficult install/uninstall algorithms has better coverage now. Other Now __fisher_list can list plugins from the cache, a fishfile/bundle and plugins that are installed/enabled or disabled. This removes __fisher_file and combines it with __fisher_list. This also removes fisher -f and replaces it with fisher -l <file> or fisher --list=<file>. Rename __fisher_parse_help to __fisher_complete and have the function create the completions automatically. This allows you to complete your commands with parseable usage help faster. The original design was fine, but this change improves auto-complete performance so it was preferred. Use __fisher_index_update when building file with Make. This helps prevent an error when using a fish version < 2.2.0. See #55 #50 #48. Add __fisher_index_update to update the index and remove previously undocumented fisher update --index. This function is designed to bypass GitHub's server network cache passing an arbitrary query string to curl like $fisher_index?RANDOM_NUMBER. This means index updates are immediately available now. Add fisher --list=url option to display local plugin url or path. Add fisher --list=bare option to display local plugins in the cache without the * enabled symbol. Prepend > to the currently enabled theme when using fisher --list[=cache]. Related #49. Prepend * to plugin names to indicate they are currently enabled when using fisher --list[=cache]. See #49.
jorgebucaran
added a commit
that referenced
this issue
Sep 7, 2018
===================== Add user key bindings support. Recall $fisher_home/functions are always before user functions in $fish_function_path. This was an early design decision in order to prevent users from redefining core functions by mistake or by means other than using plugins (recommended). In other words, you are free to create a plugin that modifies a Fisherman core function, but you can't redefine a Fisherman function privately by saving it to your user config fish. If you found a bug in a Fisherman function, instead of creating a private patch send it upstream. If you created a function that overrides a Fisherman core feature, create a plugin. This way the community can benefit from your code whenever you are ready to publish it. By default, Fisherman provides no fish_user_key_bindings, so if the user has already defined their own fish_user_key_bindings that one will not be affected. Now, plugins can define their own key bindings inside a fish_user_key_bindings.fish or key_bindings.fish at the root of their repository or inside a functions directory. You can put your key bindings inside a function or not. If you put it inside a function, the function name must be the same as the file without the .fish extension. $fisher_config/bindings.fish When a plugin with key bindings is installed for the first time or the only one with bindings is uninstalled, Fisherman will modify ~/.config/functions/fish_user_key_bindings.fish (or create it for the first time) and add a single line at the top of the fish_user_key_bindings function to source the new $fisher_config/bindings.fish. All the key bindings defined by the enabled/installed plugins are concatenated and saved to this file. This mechanism has the following advantages: Does not slow down shell start. Does not require Fisherman to provide his own fish_user_key_bindings by default. Honors any previously existing user key bindings. Allows plugin to define their own key bindings and coexist with the user's key bindings. If the user updates his fish_user_key_bindings, re-running the function does update the key bindings. Mega Refactoring The entire source code of Fisherman received a major revision and refactoring. The validation and install/uninstall mechanisms were thoroughly revised and and broken down into smaller functions easier to test as well as several other sub parts of the system. Rewrite fisher search and remove features that are mostly already covered by fisher --list and remove the ability to generate information about plugins of unknown origin. The decision to remove this feature was based in performance concerns and the result of thinking about the usability and whether it was really worth the speed tradeoff. The conclusion is I would rather have better performance and if I need to query a plugins origin I can always use fisher --list or fisher --list=url or fisher --list=author. Add $fisher_update_interval to determine if the index should update or not when a search query is taking place. The default value is 10 seconds. This means the index will not be updated if less than 10 seconds have elapsed since the last action that triggered an update in the first place. See Improve Install/Uninstall/Update status output. If a plugin fails to install decrease the total. If any plugins are skipped because they are already installed in the case of fisher install or available in the cache, but disabled in the case of fisher uninstall they are collected into an array and displayed in a new section n plugin/s skipped (a, b, c) at the bottom of the report. Improve test coverage. Tightly coupled functions were making testing increasingly difficult. Most of the test effort was basically testing whether git clone or git pull. New separation of concerns makes tests run faster and the difficult install/uninstall algorithms has better coverage now. Other Now __fisher_list can list plugins from the cache, a fishfile/bundle and plugins that are installed/enabled or disabled. This removes __fisher_file and combines it with __fisher_list. This also removes fisher -f and replaces it with fisher -l <file> or fisher --list=<file>. Rename __fisher_parse_help to __fisher_complete and have the function create the completions automatically. This allows you to complete your commands with parseable usage help faster. The original design was fine, but this change improves auto-complete performance so it was preferred. Use __fisher_index_update when building file with Make. This helps prevent an error when using a fish version < 2.2.0. See #55 #50 #48. Add __fisher_index_update to update the index and remove previously undocumented fisher update --index. This function is designed to bypass GitHub's server network cache passing an arbitrary query string to curl like $fisher_index?RANDOM_NUMBER. This means index updates are immediately available now. Add fisher --list=url option to display local plugin url or path. Add fisher --list=bare option to display local plugins in the cache without the * enabled symbol. Prepend > to the currently enabled theme when using fisher --list[=cache]. Related #49. Prepend * to plugin names to indicate they are currently enabled when using fisher --list[=cache]. See #49.
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mdziardziel@PC-076 ~/g/fisherman> make
Adding configuration to ~/.config/fish/config.fish
Downloading the index for the first time...
fish: Could not expand string “"$$spinners"”
/home/mdziardziel/git/fisherman/functions/wait.fish (line 68): set spinners "$$spinners"
^
in function “wait”,
called on line 72 of file “/home/mdziardziel/git/fisherman/functions/fisher_update.fish”,
with parameter list “--spin=pipe --log=/home/mdziardziel/.config/fisherman/cache/.debug_log
curl --max-time 5 -sS https://raw.githubusercontent.com/fisherman/fisher-index/master/INDEX > /home/mdziardziel/.config/fisherman/cache/.index.tmp
”
in function “fisher_update”,
called on standard input,
with parameter list “--index”
fisher: Connection timeout. Try again.
Ahoy! Reset your shell and type 'fisher '
read: Unknown option “alias”
/home/mdziardziel/git/fisherman/functions/fisher.fish (line 2): while read -la alias
^
in function “fisher”,
called on standard input,
with parameter list “help -a”
The text was updated successfully, but these errors were encountered: