Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix: fix nested decimal read and write #1573

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

ariesdevil
Copy link
Contributor

This PR fix the nested decimal read and write for all decimal precision, and all tests for all decimal precision and parquet versions.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6271f48) 83.06% compared to head (5f20f78) 83.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1573      +/-   ##
==========================================
+ Coverage   83.06%   83.35%   +0.28%     
==========================================
  Files         391      391              
  Lines       42898    42925      +27     
==========================================
+ Hits        35635    35780     +145     
+ Misses       7263     7145     -118     
Files Coverage Δ
...arquet/read/deserialize/fixed_size_binary/basic.rs 94.91% <100.00%> (ø)
src/io/parquet/write/fixed_len_bytes.rs 100.00% <100.00%> (ø)
src/io/parquet/write/mod.rs 90.09% <100.00%> (+13.03%) ⬆️
...rquet/read/deserialize/fixed_size_binary/nested.rs 57.75% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sundy-li sundy-li merged commit 710d6b3 into jorgecarleitao:main Oct 7, 2023
24 of 25 checks passed
@ariesdevil ariesdevil deleted the decimal branch October 7, 2023 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants