Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added extend/extend_unchecked for MutableBinaryArray #486

Merged
merged 3 commits into from
Oct 3, 2021

Conversation

VasanthakumarV
Copy link
Contributor

This PR adds TrustedLen-based extend and extend_unchecked methods for MutableBinaryArray.

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #486 (5fcd673) into main (a15044a) will decrease coverage by 0.35%.
The diff coverage is 94.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   80.33%   79.98%   -0.36%     
==========================================
  Files         374      379       +5     
  Lines       22919    23270     +351     
==========================================
+ Hits        18413    18612     +199     
- Misses       4506     4658     +152     
Impacted Files Coverage Δ
src/array/binary/mutable.rs 65.08% <93.10%> (+1.73%) ⬆️
tests/it/array/binary/mutable.rs 100.00% <100.00%> (ø)
src/io/csv/read/reader.rs 47.36% <0.00%> (-15.79%) ⬇️
src/array/dictionary/mutable.rs 70.76% <0.00%> (-5.90%) ⬇️
src/array/list/mutable.rs 66.33% <0.00%> (-4.94%) ⬇️
src/array/fixed_size_binary/mutable.rs 67.03% <0.00%> (-4.74%) ⬇️
src/array/fixed_size_list/mutable.rs 48.52% <0.00%> (-4.70%) ⬇️
src/ffi/array.rs 64.70% <0.00%> (-4.05%) ⬇️
src/bitmap/bitmap_ops.rs 93.81% <0.00%> (-4.04%) ⬇️
src/array/ffi.rs 65.00% <0.00%> (-3.43%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15044a...5fcd673. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, as usual. Two minor nits, good to go!

src/array/binary/mutable.rs Outdated Show resolved Hide resolved
src/array/binary/mutable.rs Outdated Show resolved Hide resolved
@jorgecarleitao jorgecarleitao merged commit 6c52e50 into jorgecarleitao:main Oct 3, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants