Be sure the rpc virtualenv is create from the system environment #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galaunay
force-pushed
the
Fix1674
branch
4 times, most recently
from
c9eb63b
to
322f99c
Compare
galaunay
force-pushed
the
Fix1674
branch
6 times, most recently
from
7badbfd
to
8569df1
Compare
This is necessary for venv to create a proper virtualenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow #1674.
When Elpy's RPC virtualenv is created with an virtualenv activated, the resulting RPC virtualenv was bound to the active virtualenv and (for some reasons) missing pip and some other dependencies.
This PR make sure the RPC virtualenv is created from the system environment.
PR checklist