Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings when the rpc venv is not properly installed #1706

Conversation

galaunay
Copy link
Collaborator

@galaunay galaunay commented Oct 26, 2019

PR Summary

Add additional warnings when Elpy failed to install the rpc virtualenv properly, or when pip is not properly installed in the rpc virtualenv (see #1674 for example).

PR checklist

  • Commits respect our guidelines
  • Tests are passing properly (see [here]

@coveralls
Copy link

coveralls commented Oct 26, 2019

Coverage Status

Coverage decreased (-0.3%) to 92.007% when pulling 583121a on galaunay:add-warnings-when-rpc-venv-improperly-installed into 361c212 on jorgenschaefer:master.

@galaunay galaunay force-pushed the add-warnings-when-rpc-venv-improperly-installed branch 3 times, most recently from 1f95f1a to 0a6a3aa Compare October 29, 2019 23:48
@galaunay galaunay force-pushed the add-warnings-when-rpc-venv-improperly-installed branch from 0a6a3aa to cd959ba Compare October 29, 2019 23:50
@galaunay galaunay merged commit 7b2d35e into jorgenschaefer:master Nov 1, 2019
@galaunay galaunay deleted the add-warnings-when-rpc-venv-improperly-installed branch November 1, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants