Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binance exchange support for Bitcoin-DCA #53

Merged
merged 10 commits into from
May 24, 2021
Merged

Conversation

jorijn
Copy link
Owner

@jorijn jorijn commented May 2, 2021

This PR will bring support for the Binance exchange. It allows purchasing Bitcoin with base currencies like USD(T/C), EUR, GBP, and many more. See https://www.binance.com/en/markets for all available Bitcoin markets.

Supporting the Binance exchange also brings back XPUB support. This ensures a new, unused, Bitcoin address for each automated withdrawal made by Bitcoin-DCA.

@jorijn jorijn marked this pull request as ready for review May 24, 2021 12:47
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
2.8% 2.8% Duplication

@jorijn jorijn merged commit ffd773f into master May 24, 2021
@jorijn jorijn deleted the feature/51-binance-support branch May 24, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant