Add missing environment variable for config file #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisroovers
added
the
status: needs-tests
|
Thanks for this PR. I do think this needs tests. If I recall correctly, I hadn't added this env var before exactly because the test would require a bit of a different pattern and I didn't want to do that work at the time. Appreciate the contribution. I'll get this merged at some point, once I find some time. |
Most of the gitlint command-line options have corresponding environment variables following the format GITLINT_<commandline_option>, added in 69aa5ff.
|
Sorry for taking so long to get back to you. I've added tests for both the I'd just like to say that I've enjoyed hacking on gitlint -- it was a pleasure to dig into! |
This was referenced Mar 9, 2022
Work on adding the GITLINT_CONFIG environment variable brought to attention that the most similar environment variable, GITLINT_EXTRA_PATH, was also missing a test.
Fixed a typo and modified paths to match other example paths in the docs.
|
Made a few minor doc tweaks and merged! Thanks for submitting the PR! Not sure when I'll push out the next release, likely to be weeks, maybe few months... |
jorisroovers
pushed a commit
that referenced
this pull request
Apr 16, 2022
Add missing environment variable for config file Most of the gitlint command-line options have corresponding environment variables following the format GITLINT_<commandline_option>. GITLINT_CONFIG was notably missing. Co-authored-by: Joris Roovers
jorisroovers
added a commit
that referenced
this pull request
Nov 16, 2022
- Python 3.11 support - Last release to support Python 3.6 - Behavior Change: In a future release, gitlint will be switching to use `re.search` instead of `re.match` semantics for all rules. (#254) - gitlint no longer uses the `sh` library by default in an attempt to reduce external dependencies. - `--commits` now also accepts a comma-separated list of commit hashes, making it possible to lint a list of non-contiguous commits without invoking gitlint multiple times (#283) - Improved handling of branches that have no commits (#188) - Support for `GITLINT_CONFIG` env variable (#189) - Added a new `gitlint-ci` pre-commit hook, making it easier to run gitlint through pre-commit in CI (#191) - Contrib Rules: - New `contrib-disallow-cleanup-commits` rule (#312) - New `contrib-allowed-authors` rule (#358) - User Defined rules: - Gitlint now recognizes `fixup=amend` commits, available as `commit.is_fixup_amend_commit=True` - Gitlint now parses diff **stat** information, available in `commit.changed_files_stats` (#314) - Bugfixes: - Use correct encoding when using `--msg-filename` parameter (#310) - Various documentation fixes (#244) (#263) (#266) (#294) (#295) (#347) (#364) - Under-the-hood: - Dependencies updated - Moved to blacked for formatting - Fixed nasty CI issue (#298) - Unit tests fix (#256) - Vagrant box removed in favor of github dev containers (#348) - Removed a few lingering references to the `master` branch in favor of `main` - Moved roadmap and project planning to github projects Full Release details in CHANGELOG.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the gitlint command-line options have corresponding environment
variables following the format GITLINT_<commandline_option>, added in
69aa5ff.
The only remaining command-line option that's missing a corresponding environment variable is the
-coption for overriding individual configuration options.Additionally, I made the assumption in the documentation that this change would get released in 1.16.0.
I investigated adding tests, but I chose not to for a few, opinionated, reasons
GITLINT_EXTRA_PATH, does not have a test