Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated copyright year dynamically. #3148

Conversation

Koshux
Copy link

@Koshux Koshux commented Feb 5, 2024

Updated the copyright year to be dynamic instead of requiring a PR each time.

@josdejong
Copy link
Owner

That is a nice one indeed.

I like to automate that, but I think it would be better to insert the right year during a build step, not at runtime. What do you think?

@josdejong
Copy link
Owner

Closing this PR now, please create a new one if you manage to get the year generated during a build step

@Koshux
Copy link
Author

Koshux commented Feb 16, 2024

Apologies, I did not realise you had replied. Let me look into the configured build steps and revert back to you.

On the top of my mind however, I personally do not see any advantages over moving it to the build steps since the year would automatically update whenever the page loads rather than whenever a release is pushed.

@josdejong
Copy link
Owner

Thanks!

On the top of my mind however, I personally do not see any advantages over moving it to the build steps since the year would automatically update whenever the page loads rather than whenever a release is pushed.

In general I think it is best to do as much pre-processing as possible: serving plain HTML is more robust and faster than requiring JS for it. It can for example be helpful for Search Engine Optimization (SEO) if the page is directly readable. It's for a reason that there is a big interest now in techniques like server side rendering, and solutions like AstroJS.

@Koshux
Copy link
Author

Koshux commented Feb 17, 2024

Most definitely however I came across some content recently that Google actually allows JS to be executed due to the larger demand for frameworks. Whilst SSR is still largely better for SEO, SEO in itself is based on search engine techniques specific to the company. Google recently announced that changes will be coming to SEO because of LLM and dependency on dynamic content.

https://searchengineland.com/google-to-cut-thousands-of-search-quality-rater-jobs-after-dropping-contract-with-appen-436739

So yes I agree but also we have to keep in mind that some JS is still fine to keep if it serves well. Not in this case particularly but generally speaking :)

josdejong added a commit that referenced this pull request Feb 21, 2024
@josdejong
Copy link
Owner

Yeah true. Still, I like prefer simple static content when possible, keep it simple :).

I had a look to see if we can fill in the date when generating the site (see StackOverflow), and this is possible 🎉, see commit f4bb24d. So the year is now automatically kept up to date.

Thanks for triggering this issue and thinking along!

@josdejong josdejong closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants