-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1600p_SMF_en support #101
Conversation
@josdemmers, great work with the tool, found it recently and it was very fun to check how you made it work! Also, the Debug mode is awesome! The reason this PR is a draft is that I could not manage to test it locally, as the app only allows to "download" presets already in master. I changed UpdateSystemPresetInfo() to use my local file instead of the uri, and it finally found my preset, but I still have to download it and the button is greyed out 😅 Maybe this could be a future update for debug mode. Thanks you! |
Thank you for the extra system preset. Good to hear you like the project! Regarding the download button, that is disabled while the overlay is active. If you disable it you can download and change the system preset. For local testing you don't have to use the Download button. You can directly use the selection on the left. |
Looked at the added images and you probably want to make them a bit smaller so they have less background noise. If you have too much background it could cause false positives when looking for the icons. You could look for example at the |
Updated the icons as suggested. While testing locally, the items were never detected by the debugger. I had it working on my 1440 monitor though with the 1440p_SMF_en preset, so it could be the icons I captured are now too cropped, or am I missing something? |
Your icons are looking fine now. Must be something else. You mentioned a 1440p monitor. That pc has multiple monitors connected? //edit
|
Your intuition was on point. After testing individually with each monitor (laptop 1600p and widescreen 1440p), the app worked correctly. I was using it without restarting the app when changing monitors, which caused the issue. Noticed one thing, both on 1600p_SMF_en and 1440p_SMF_en presets, the unique icon was not detected. |
Also confirm that controller mode worked in both presets. |
Great, going to merge this tomorrow. |
Added 1600p Medium font support for SDR.