Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1600p_SMF_en support #101

Merged
merged 7 commits into from
May 25, 2024
Merged

Conversation

amorimdiogo
Copy link
Contributor

@amorimdiogo amorimdiogo commented May 22, 2024

Added 1600p Medium font support for SDR.

@amorimdiogo
Copy link
Contributor Author

amorimdiogo commented May 22, 2024

@josdemmers, great work with the tool, found it recently and it was very fun to check how you made it work! Also, the Debug mode is awesome!

The reason this PR is a draft is that I could not manage to test it locally, as the app only allows to "download" presets already in master. I changed UpdateSystemPresetInfo() to use my local file instead of the uri, and it finally found my preset, but I still have to download it and the button is greyed out 😅
image

Maybe this could be a future update for debug mode.

Thanks you!

@josdemmers
Copy link
Owner

Thank you for the extra system preset. Good to hear you like the project!

Regarding the download button, that is disabled while the overlay is active. If you disable it you can download and change the system preset.

For local testing you don't have to use the Download button. You can directly use the selection on the left.
Add your preset to the .\Diablo4Companion\Images\ folder and restart the app and you will be able to select it.

@josdemmers
Copy link
Owner

josdemmers commented May 22, 2024

Looked at the added images and you probably want to make them a bit smaller so they have less background noise. If you have too much background it could cause false positives when looking for the icons.
Should be fine if you add only 2 extra pixels around the icons.

You could look for example at the 1440p_SMF_en images.

@amorimdiogo amorimdiogo marked this pull request as ready for review May 22, 2024 16:39
@amorimdiogo
Copy link
Contributor Author

Updated the icons as suggested.

While testing locally, the items were never detected by the debugger. I had it working on my 1440 monitor though with the 1440p_SMF_en preset, so it could be the icons I captured are now too cropped, or am I missing something?

@amorimdiogo
Copy link
Contributor Author

amorimdiogo commented May 22, 2024

Maybe the issue could be the height, as this is a taller aspect ratio (2560x1600, 16:10), and the shift key is not visible on the item.

image

@josdemmers
Copy link
Owner

josdemmers commented May 22, 2024

Your icons are looking fine now. Must be something else.
Let's first try to get it working at your end before merging it.

You mentioned a 1440p monitor. That pc has multiple monitors connected?

//edit
There are two things you could try for testing.

  1. When you start the app make sure it opens on the monitor that you are using for Diablo. This is because the app is probably using the resolution/scaling setting of that monitor.
  2. Or temporarily disconnect the other monitor so you only have the 1600p connected. Start the app after the monitor is disconnected.

@amorimdiogo
Copy link
Contributor Author

Your intuition was on point.

After testing individually with each monitor (laptop 1600p and widescreen 1440p), the app worked correctly. I was using it without restarting the app when changing monitors, which caused the issue.

Noticed one thing, both on 1600p_SMF_en and 1440p_SMF_en presets, the unique icon was not detected.

1440p

@amorimdiogo
Copy link
Contributor Author

Also confirm that controller mode worked in both presets.

@josdemmers
Copy link
Owner

Great, going to merge this tomorrow.

@josdemmers
Copy link
Owner

Noticed one thing, both on 1600p_SMF_en and 1440p_SMF_en presets, the unique icon was not detected.

Probably working fine. Unique aspects are not marked because you can't extract them.
You can verify if it works at the debug tab.

image

@josdemmers josdemmers merged commit eb10ad6 into josdemmers:master May 25, 2024
@josdemmers
Copy link
Owner

Merge is done, one last question. What is the ingame brightness you are using?

Is that the same as the default?
332195335-032e9499-7909-415e-ba32-362dbf053196

Reason is I was testing and updating some of the other presets and noticed that with the default ingame brightness setting changing this app setting worked better:

  • Brightness Thresshold: 60 --> 70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants