Add gradualizer_tracer for efficient troubleshooting #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
reviewed
Sep 14, 2022
| @@ -24,6 +26,8 @@ start_application(Opts) -> | |||
| %% If gradualizer is run as an escript this should not be necessary, but better safe than sorry. | |||
| ok = application:load(gradualizer), | |||
| application:set_env(gradualizer, options, Opts), | |||
| %% We could start the tracer based on a CLI flag, but it's config is compile-time anyway. | |||
| %gradualizer_tracer:start(), | |||
There was a problem hiding this comment.
Is this tracing enabled by un-commenting this line?
It doesn't seem very convenient to me...
There was a problem hiding this comment.
Given the tracer has to be customised in code to make it useful for a practical test case / found bug, I think that uncommenting this single line is a minor detail :) Seriously, debugging the infinite loops, for example, took me literally hours of working with different examples, reading the code, comparing against hypothetical fixes on various branches, etc. Uncommenting this line IMO is not a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some machinery I'm keeping on the git stash for when it's needed, but I think it doesn't hurt to share it here.