fix filename when renaming through nameCallback #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
|
I would, but I have to little knowledge on how I can test beforeSave on this. |
|
I've seen them but didn't get to an actual working test. |
|
What hold up are you having with writing tests? I'm headed into a meeting in a little, but am available as |
|
This gist can explain the issue: |
josegonzalez
added a commit
that referenced
this pull request
Feb 17, 2016
fix filename when renaming through nameCallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nameCallback is used there is an inconsistence between the filename in the database and the actual file since the calculated filename only is assigned to the entity, never to the file itself.