-
Notifications
You must be signed in to change notification settings - Fork 254
Fix when using empty settings #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
continue; | ||
} | ||
|
||
$settings = is_array($settings) ? $settings : []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not properly setup the settings in the initialize?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking the same, just like Hash::normalize
too much :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So after the Hash::normalize()
call, detect an invalid config and fix it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, we'd better loop the config ourselfs, otherwise it's doing the job twice. RIP Hash::normalize
.
The error is till happening for me. I'm using 3.6.2 version. Error : This works :
This doesn't work :
Should I open a new issue ? |
@KevinMasson mind filing an issue? |
Fix for #371