Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay calling validate on changeset form input to avoid errors #96

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

josemarluedke
Copy link
Owner

When using ember v3.22, one could encounter the following error when submitting a form pressing Enter in the input. That would cause the onsubmit event on the form + the onblur on the input in which both calls validate...

Error: Assertion Failed: You attempted to update `_errors` on `changeset:[object Object]`, but it had already been used previously in the same computation.  Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.

@josemarluedke josemarluedke added the Type: Bug Something isn't working label Oct 11, 2020
@josemarluedke josemarluedke merged commit 895bbb4 into master Oct 12, 2020
@josemarluedke josemarluedke deleted the bug/changeset-ember3.22 branch October 12, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant