Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the same issue as the user in #1 where the URL I was trying to download from was too large, causing the automatically generated path for the temporary filenames to be too long and resulting in the error message:
To resolve this, I've added a CLI option of
--randomfilenames
which will cause all temporary filenames to be converted into UUIDs instead of their full names, thus all filenames will be shortened to an appropriately small length. Because of the way the m3u8 file was used with ffmpeg, the filenames need to be preserved and inserted into the updated m3u8 file, so this is achieved by creating a lookup table in the M3u8Downloader class for the filenames that maps the original full filename to the shortened UUID name, this way the m3u8 file may be reconstructed with a consistent random filename for the final combination of fragments into the full file.