Update context 'remove' flag var name to avoid collision with 'text' OT type method #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context remove flag name was updated to avoid collision with the method 'remove' of the 'text' OT type. This collision was causing issues that are documented on the ShareJS GitHub repository.
nateps
added a commit
that referenced
this pull request
Jul 18, 2015
Update context 'remove' flag var name to avoid collision with 'text' OT type method
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380.
I've updated the context
'remove'flag var name to'shouldBeRemoved'as proposed on the discussion of the issue mentioned above. Context remove flag name was updated to avoid collision with the methodremove(pos, length, callback)of the'text'OT type. This collision was causing issues that are documented on the ShareJS GitHub repository, such as #380 and #382.