Add multinomial sampling support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice!! I see you're still adding commits here - ping me when you're done |
|
I'm done :)
It looks like this: The numbers on the right indicate the number of
possible tokens.
Let me know if you don't want the display on the right, I can remove, but
it's cool.
…On Fri, 17 Feb 2023 at 22:46, josephrocca ***@***.***> wrote:
Nice!! I see you're still adding commits here - ping me when you're done
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMNJF2XLDKGONTHF3DHV3WYBV3NANCNFSM6AAAAAAVAAUY2M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Just tested it - nice work! Will add a tooltip on those numbers and also credit you in readme |
|
Thanks! |
|
Q: What is the red underline for? |
|
Just means that the number of possible options is greater than 1. Just to
see what the number is applying to.
…On Fri, 17 Feb 2023 at 23:14, josephrocca ***@***.***> wrote:
Q: What is the red underline for?
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMNJEFI2ZLGY2SWN7RMBTWYBZF3ANCNFSM6AAAAAAVAAUY2M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.