fix #129 -external links

[marcobiedermann]

Only open external links in a new tab

[marcobiedermann]

@joshbuchea @scottaohara Can we merge this in?

[scottaohara]

If we add this, could you also make sure to add rel="noopener noreferrer" to the off-site links as well? more information about target="blank" security issues here

[joshbuchea]

👍 looks good to me

[joshbuchea]

What do you think @scottaohara?

[tomlutzenberger]

On Line 38 in _layouts/default.html, you initialize var i and do it again in the for-Loop.
I would change it either to remove Line 38 and say for(var i = 0; or leave the first "parameter" in the for-Loop empty.

[marcobiedermann]

@tomlutzenberger Sorry, my bad. I actually wanted to declare it outside the for loop and assign a value inside the loop to it.
I do not recommend your suggestion: for (var i = 0; …).

JavaScript hoists variables to the top of the current scope.
Declaring the variable first and assign a value later is slightly more performant. You actually would not notice any difference but I am a fan of more efficient code. Lots of small things add up to a bigger impact :)

[marcobiedermann]

@tomlutzenberger fixed in 19e4127