Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DensityInterface.jl #40

Closed
wants to merge 3 commits into from
Closed

Use DensityInterface.jl #40

wants to merge 3 commits into from

Conversation

ParadaCarleton
Copy link
Contributor

@ParadaCarleton ParadaCarleton commented Sep 19, 2022 •
edited
Loading

The PDF function should overload DensityInterface.jl's logpdf for a consistent interface. (pdf is then defined as exp(logpdf).)

@ParadaCarleton ParadaCarleton marked this pull request as ready for review September 19, 2022 21:47
@joshday
Copy link
Owner

joshday commented Sep 19, 2022

I appreciate the pointer to DensityInterface, but it doesn't look like that package has a logpdf function. I'd be happy to adopt a common interface, but I don't think this PR is the correct way to do it.

@ParadaCarleton
Copy link
Contributor Author

I appreciate the pointer to DensityInterface, but it doesn't look like that package has a logpdf function. I'd be happy to adopt a common interface, but I don't think this PR is the correct way to do it.

Crap, it's logdensityof, sorry. Distributions is the one defining logpdf specifically.

@ParadaCarleton ParadaCarleton mentioned this pull request Sep 19, 2022
Open
@joshday joshday mentioned this pull request Dec 5, 2022
Open
@joshday joshday closed this Apr 25, 2023
@ParadaCarleton ParadaCarleton deleted the patch-1 branch April 25, 2023 20:47
@ParadaCarleton ParadaCarleton restored the patch-1 branch June 21, 2023 19:12
@joshday joshday reopened this Jun 21, 2023
@joshday joshday closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ParadaCarleton @joshday