Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlideDirection -> SlideTransition #5

Closed
yonomitt opened this issue Sep 9, 2022 · 1 comment · Fixed by #14
Closed

SlideDirection -> SlideTransition #5

yonomitt opened this issue Sep 9, 2022 · 1 comment · Fixed by #14

Comments

@yonomitt
Copy link
Contributor

yonomitt commented Sep 9, 2022

In the future, it might be handy to add more transitions between slides. For instance, in Keynote, I use Dissolve quite often, and would miss it here. This would require adding a new case to the SlideDirection enum.

However, at the point of adding more transition types, the name no longer makes sense. It might be better to rename it to SlideTransition to more accurately reflect the functionality.

@joshdholtz
Copy link
Owner

I completely agree with this! I will get this renamed 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants