-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Control Over Item Data #106
Comments
Let me think about the best way to go about these.
Fundamentally, Green check will only ever be reserved for items we can see that you have via the API. If there’s something that should be green checked but isn’t, that’s a bug (plz report!) or a limitation, but this new “manually mark as collected” should help In the meantime.
‘Deleting’ Items marked as dismantles is good. That should be fairly straightforward.
This ‘ignores’ or ‘not interested’ is interesting though. Would it just visually mark items, or would it hind them from the default view completely? I’m thinking a filter option could play into this.
Thanks for the feedback! The good thing here is that there’s now a nice foundation to add these sorts of features in.
…
On May 19, 2018 at 6:23 pm, <TheWolfLegate ***@***.***)> wrote:
Being able to manually mark something has dismantled is a huuuuge QoL update that I am greatly appreciative of. I am curious about further functionality being added to it. For example, the site is marking a few items as being dismantled for me, though I have never acquired them. Or The site is marking emotes as dismantled once the emote wheel update hit. Would it be possible to gain complete control over how an item is marked? Allow us to mark it as: Acquired/In Vault/In Collection (Green Check), Dismantled (Grey Check), Not Interested (Red X), and Desired/Favorited (Gold Star). Would something like this be possible to add?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (#106), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAC0PhQZFYiIXiIWzCvcYGV4ie6R4FkGks5t0EcbgaJpZM4UFxCu).
|
Okay, so yeah green check makes sense the way it is. The only things that are showing as dismantled when they should be green checked are emotes. I think the recent update that added the emote wheel broke things because where they are stored is a different location. It's not so much 'deleting' the items marked as dismantled, more just that the game has marked some items as dismantled when I have never acquired them I'm thinking for the 'Ignored/Not Interested' option, it'll tag the item with a red X, just like the green/grey checkmark, and then fade it out. If you deselect the filter option of 'collected', then they will no longer show. That way you can now the items are still in the game, but you just aren't personally interested in them. Of course! This site is a huge help for me as a collector, so if there is anything I can do or suggest to improve it I happily will. Thanks for all the hard work you put into it |
I still have a bunch of items marked as "Dismantled" that I never owned, as well. (Borealis and a number of unobtainable emblems and emotes, for example) I would like the ability to unmark items even if they weren't manually marked. I'm also curious why there's a distinction between "Dismantled" and "Manually marked as collected" in the tooltip as opposed to something like a unified "Collected" label |
Yesterday I pushed "Forget dismantled" that should cover this. Lets keep this open to track the remaining bits :) |
Being able to "Forget Dismantled" is perfect. I second having a unified "Collected" as opposed to the two different ones. Also, and progress on adding a "Not Interested" (Red X) or "Desired" (Gold Star) label? |
Also, as a slightly related thing, items "Manually marked as collected" don't disappear when the "Collected Items" filter is unchecked like "Collected" or "Dismantled" items do |
Fixed the "Collected items" filter issue |
@JTF195 I initially thought of introducing like a blue tick for manually collected items, but i thought that the same grey tick for "this is something that we can't verify you have", with further explanation in the tooltip/modal was a neater route of keeping things simple and adding the extra complexity for those that want it hidden. |
Being able to manually mark something has dismantled is a huuuuge QoL update that I am greatly appreciative of. I am curious about further functionality being added to it. For example, the site is marking a few items as being dismantled for me, though I have never acquired them. Or The site is marking emotes as dismantled once the emote wheel update hit. Would it be possible to gain complete control over how an item is marked? Allow us to mark it as: Acquired/In Vault/In Collection (Green Check), Dismantled (Grey Check), Not Interested (Red X), and Desired/Favorited (Gold Star). Would something like this be possible to add?
The text was updated successfully, but these errors were encountered: