Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 support #15

Open
sandrotosi opened this issue Jul 7, 2015 · 5 comments
Open

python3 support #15

sandrotosi opened this issue Jul 7, 2015 · 5 comments

Comments

@sandrotosi
Copy link

hi! it would be great if this library could be ported to py3k

@amorphic
Copy link

amorphic commented Sep 7, 2015

I also need Python 3.x support.

Would you be willing to accept a PR and release a v0.2 if said PR passed tests under 2.7 and 3.4?

@amorphic
Copy link

amorphic commented Sep 8, 2015

...because I would be more than happy to write and submit that PR to get an official release that's Python 3.x compatible...;)

I'd also be glad to help manage the repo if you don't have time? I see there are a couple of outstanding PRs and Issues and I could give you a hand merging them, writing more tests, preparing releases etc.

This is a great library that is going to prove useful to more and more people as both Websockets and Tornado grow in popularity.

@sandrotosi
Copy link
Author

@amorphic if you write such PR, people will use it/comment/provide feedback, so... just do it :)

@joshmarshall
Copy link
Owner

I would love the help! All the tests run on Travis at
https://travis-ci.org/joshmarshall/tornadorpc and I can set it up so that
it releases tagged branches on master to PyPI as well. If necessary I can
add folks as collaborators.

Thanks!


Josh Marshall
(254) 498-0366

On Tue, Sep 8, 2015 at 10:34 AM, Sandro Tosi notifications@github.com
wrote:

@amorphic https://github.com/amorphic if you write such PR, people will
use it/comment/provide feedback, so... just do it :)


Reply to this email directly or view it on GitHub
#15 (comment)
.

@amorphic
Copy link

Ok, so the first step is to get jsonrpclib updated for py3k:

joshmarshall/jsonrpclib#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants