Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert @stripe/stripe-js to a peer dependency #113

Merged
merged 2 commits into from
May 5, 2024

Conversation

hmnd
Copy link
Contributor

@hmnd hmnd commented May 5, 2024

fixes #110

  • update @stripe/stripe-js to v3 and changes to a dev+peer dep
  • update docs to reflect @stripe/stripe-js requirement

Copy link

vercel bot commented May 5, 2024

@hmnd is attempting to deploy a commit to the Joshua Nussbaum's projects Team on Vercel.

A member of the Team first needs to authorize it.

@joshnuss
Copy link
Owner

joshnuss commented May 5, 2024

Thanks @hmnd!

Are eslint updates and dependency updates related to updating the peer dependency? Or can they be in a separate PR?

@hmnd
Copy link
Contributor Author

hmnd commented May 5, 2024

Can split them out into a separate PR!

@hmnd hmnd force-pushed the feature/update-stripe-js branch from bef02c5 to 1b5854e Compare May 5, 2024 02:09
@hmnd hmnd mentioned this pull request May 5, 2024
Copy link
Owner

@joshnuss joshnuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left 2 small comments

src/routes/+page.md Outdated Show resolved Hide resolved
src/routes/+page.md Outdated Show resolved Hide resolved
@hmnd hmnd force-pushed the feature/update-stripe-js branch from 1b5854e to 1f20940 Compare May 5, 2024 02:28
vite.config.js Outdated Show resolved Hide resolved
@hmnd hmnd force-pushed the feature/update-stripe-js branch from 1f20940 to 96e8a66 Compare May 5, 2024 03:23
@joshnuss joshnuss self-requested a review May 5, 2024 03:24
@joshnuss joshnuss merged commit 224ec6d into joshnuss:main May 5, 2024
1 check failed
@joshnuss
Copy link
Owner

joshnuss commented May 5, 2024

Thanks @hmnd!! Much appreciated

@hmnd hmnd deleted the feature/update-stripe-js branch May 5, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

types are incompatible with latest @stripe/stripe-js@3.3.0
2 participants