Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax coloring #19

Closed
svipas opened this issue May 28, 2017 · 1 comment
Closed

Syntax coloring #19

svipas opened this issue May 28, 2017 · 1 comment

Comments

@svipas
Copy link

svipas commented May 28, 2017

Hello,

In my opinion default VS Code syntax coloring is way better than this one. Better improve some of them which are not in VS Code by default, like colored comments and so on. Because right now VS Code default syntax coloring is easier to read. I was like, cool Babel plugin for VS Code which will improve syntax coloring, but the true is, it does nothing at all. Sorry, but this is true, you can really make this plugin better, but you need to improve it.

Thanks

@joshpeng
Copy link
Owner

joshpeng commented May 28, 2017

Thanks for your thoughts, but it really depends on the tmTheme you are using. In more recent releases, VS Code has significantly altered their own grammar scopes and themes. This plugin was made a long time before that and was designed to be used in conjunction with tmThemes that used more or less "standardized" scopes from other editors. Back then VS Code had its own twist on scoping and that made porting tmThemes look completely different than how they did in Sublime Text. This plugin addressed that. To use this grammar you'll want to pair it with a theme that uses the "standardized" scopes. I am not certain how VS Code's new default themes interact with this grammar. It is very likely that they play better with VS Code's own grammar because they would be scoped identically.
Tldr: be sure to match apples to apples in terms of grammar and tmTheme.

Please also note that this grammar was intended to match Sublime Text's Babel package, for better or worse, and not necessarily for "best correctness". At time of release, it was a near perfect 1:1 port, but since then many changes on VS Code have occurred and I can no longer guarantee 1:1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants