Prevent enter key submitting the form in windows #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a RTE such as Redactor, the window has a tendency to submit the form when hitting enter. This breaks the ability to add line breaks in the editor. This might actually be Redactor-specific as it defaults to an inline editor, while TinyMCE and others default to an iframe and the enter might not trigger in the form.
|
so, has this been fixed, because in items.grid.js the addition just removes the buttons. Enter still submits the form instead of giving a return in Redactor. |
|
Ah crap, I totally goofed up this PR. Inserted of setting I must've fixed this in my MODX install and send a PR without actually testing the committed change. |
|
Hmmm.. guess I shouldn't merge things in the middle of the night. This change hasn't been uploaded to the MODX package manager yet was waiting for some time to include a couple other things. Should be in the next few days. See issue #25 for updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a RTE such as Redactor, the window has a tendency to submit the form when hitting enter. This breaks the ability to add line breaks in the editor.
This might actually be Redactor-specific as it defaults to an inline editor, while TinyMCE and others default to an iframe and the enter might not trigger in the form.