make string type identifiers work (type coersion)

joshthecoder · May 13, 2012 · f58189c · f58189c
1 parent e3bab35
commit f58189c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/struct.js b/lib/struct.js
@@ -169,6 +169,10 @@ function set (buffer, offset, value) {
 
 function defineProperty (name, type) {
   debug('defining new struct type field', name)
+
+  // allow string types for convenience
+  type = ref.coerceType(type)
+
   assert(!this._instanceCreated, 'an instance of this Struct type has already '
       + 'been created, cannot add new "fields" anymore')
   assert.equal('string', typeof name, 'expected a "string" field name')

diff --git a/test/struct.js b/test/struct.js
@@ -94,6 +94,22 @@ describe('Struct', function () {
     assert.equal(400, ps.childB.b)
   })
 
+  describe('string type identifiers', function () {
+
+    it('should work with string type identifiers', function () {
+      var S = Struct({
+          'int': 'int'
+        , 'long': 'long'
+        , 'string': 'string'
+      })
+
+      assert.strictEqual(ref.types.int, S.fields.int.type)
+      assert.strictEqual(ref.types.long, S.fields.long.type)
+      assert.strictEqual(ref.types.Utf8String, S.fields.string.type)
+    })
+
+  })
+
   describe('offsets and sizeofs', function () {
 
     function test (structType, testNumber) {