-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not download all volunteer positions #55
Comments
- Fix incomplete volunteer experiences - LI is paginating the entries, so fix is to check for truncated results and if so, use pagination DASH endpoint. Fixes #55 - Chore: Add ignore-rev entry for previous large linting commit
@fkrauthan Thanks for reporting. I can confirm this issue exists - for certain items within a profile, LinkedIn will only load the first three entries, and require that subsequent entries be loaded lazily, with pagination (e.g., if you have 5 volunteer entries, you get the first 3 on the initial page load, and the final 2 have to be separately loaded). I've added code to check if volunteer experiences are truncated, and if so, perform the necessary action to load and parse the remaining entries. This fix has been rolled into the new Thanks for reporting, and also kudos on having that many volunteer experiences! 😄 |
haha thanks. Yeah I am currently redoing my website and plan to regenerate most of my about me page based on linkedin data so I've noticed that some stuff was missing :D I did actually build a quick local fix for that as well. But I was not able to figure out how to retrieve them in the proper order (the only endpoint I could find returns them in a random order). |
😬 Whoops, I'm like 99% certain I need to reopen this issue now lol. I totally forgot about ordering and although |
I also tried to check what LinkedIn itself is issuing to load the rest of volunteer entries but couldn't see any API call. But to be honest a lot of the way linkedin does looks rather strange. |
- Refactor DB builder, try to do a better job of preserving original order of LI entities, if response includes a direct `*elements* urn array. Should fix ordering issue in #55 - Cleanup typo
@fkrauthan OK, ordering should fixed now too (in latest And about the way LinkedIn internal APIs / loaders work... yeah, they are indeed strange. |
Perfect I will give this and the other ticket a try probably tomorrow :) |
It seems like for some reason it does not download all volunteer positions (only top 3 are included in the json).
The text was updated successfully, but these errors were encountered: